Skip to content

Pin aquasecuriy/setup-trivy to hash instead of tag#456

Merged
simar7 merged 3 commits into
aquasecurity:masterfrom
lhotari:lh-pin-setup-trivy-to-hash
Apr 9, 2025
Merged

Pin aquasecuriy/setup-trivy to hash instead of tag#456
simar7 merged 3 commits into
aquasecurity:masterfrom
lhotari:lh-pin-setup-trivy-to-hash

Conversation

@lhotari

@lhotari lhotari commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

Fixes #423

Pin aquasecurity/setup-trivy to hash instead of a tag so that GitHub Actions
"allowing select actions" feature can be used to whitelist the dependent action by a hash.
This is needed since some organizations have a policy to only allow pinned 3rd party actions to
be used. "Pin actions to a full length commit SHA" is recommended by GitHub and many organizations follow this best practice.

It's not currently possible to use trivy-action since the dependent action isn't pinned. This PR fixes that. More details in #423.

@CLAassistant

CLAassistant commented Apr 2, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@simar7 simar7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, what do you think @DmitriyLewen?

Comment thread action.yaml Outdated

@DmitriyLewen DmitriyLewen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and logical for me.

Left small comment

@lhotari lhotari requested a review from DmitriyLewen April 7, 2025 06:46

@DmitriyLewen DmitriyLewen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhotari Thanks for your work!

LGTM

cc. @simar7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow pinning setup-trivy by hash

4 participants