Skip to content

--dry-run flag hard fix; Cosmos-SDK v0.45.8 version bump#216

Merged
iTiky merged 1 commit into
mainfrom
dryrun_fix
Sep 14, 2022
Merged

--dry-run flag hard fix; Cosmos-SDK v0.45.8 version bump#216
iTiky merged 1 commit into
mainfrom
dryrun_fix

Conversation

@iTiky

@iTiky iTiky commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

I've also bumped the version 'cause I was hoping it would help 🤷‍♂️

@iTiky iTiky requested review from edjroz and fdymylja September 8, 2022 13:49
@codecov

codecov Bot commented Sep 8, 2022

Copy link
Copy Markdown

Codecov Report

Merging #216 (6025064) into main (768cbc2) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   64.21%   64.16%   -0.06%     
==========================================
  Files          59       59              
  Lines        2356     2358       +2     
==========================================
  Hits         1513     1513              
- Misses        778      779       +1     
- Partials       65       66       +1     
Impacted Files Coverage Δ
x/rewards/ante/min_cons_fee.go 70.00% <0.00%> (-7.78%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iTiky iTiky marked this pull request as ready for review September 12, 2022 11:20
@iTiky

iTiky commented Sep 12, 2022

Copy link
Copy Markdown
Contributor Author

The Cosmos SDK issue: cosmos/cosmos-sdk#13202
I'm afraid this won't be fixed soon, so I suggest this "ugly" solution for now.

@iTiky iTiky merged commit a0af2a1 into main Sep 14, 2022
@iTiky iTiky deleted the dryrun_fix branch September 14, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants