x/rewards UX#217
Merged
Merged
Conversation
Contributor
Author
|
Changes based on Augusto feedback to Frojdi |
Codecov Report
@@ Coverage Diff @@
## main #217 +/- ##
==========================================
- Coverage 64.21% 64.03% -0.19%
==========================================
Files 59 59
Lines 2356 2358 +2
==========================================
- Hits 1513 1510 -3
- Misses 778 783 +5
Partials 65 65
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
edjroz
approved these changes
Sep 12, 2022
- WithdrawRewards by limit: if a 0 limit is provided (Msg/WASM bindings), the MaxWithdrawRecords param value is used; - Test to define the max MaxWithdrawRecords param value is added and the default is adjusted; - Test to define the max page limit for querying RewardsRecord objs is added and that limit is used check/create page request (Query/WASM bindings);
iTiky
force-pushed
the
augusto_feedback
branch
from
c951ba6 to
796dc66
Compare
fdymylja
approved these changes
Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x/rewards: