Skip to content

tests: Adding msg server tests for x/rewards#236

Merged
spoo-bar merged 3 commits into
mainfrom
spoorthi/msgsrvr-testing
Jan 10, 2023
Merged

tests: Adding msg server tests for x/rewards#236
spoo-bar merged 3 commits into
mainfrom
spoorthi/msgsrvr-testing

Conversation

@spoo-bar

Copy link
Copy Markdown
Contributor

Closes: #234

Added tests for

  • SetContractMetadata
  • WithdrawRewards

@spoo-bar spoo-bar requested a review from fdymylja January 10, 2023 11:16
@codecov

codecov Bot commented Jan 10, 2023

Copy link
Copy Markdown

Codecov Report

Base: 65.17% // Head: 66.52% // Increases project coverage by +1.35% 🎉

Coverage data is based on head (1d3a35e) compared to base (edeae39).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   65.17%   66.52%   +1.35%     
==========================================
  Files          57       57              
  Lines        3394     3394              
==========================================
+ Hits         2212     2258      +46     
+ Misses       1116     1070      -46     
  Partials       66       66              
Impacted Files Coverage Δ
x/rewards/keeper/msg_server.go 100.00% <0.00%> (+92.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fdymylja fdymylja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM:)

@spoo-bar spoo-bar merged commit 1debe67 into main Jan 10, 2023
@spoo-bar spoo-bar deleted the spoorthi/msgsrvr-testing branch January 10, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(x/rewards): add testing to the MsgServer

2 participants