feat(x/rewards): Contract premium - Genesis#275
Merged
fdymylja merged 9 commits intoFeb 15, 2023
Conversation
vidhanarya
force-pushed
the
contract-premium-genesis
branch
from
020c5a0 to
b374eeb
Compare
spoo-bar
previously requested changes
Feb 10, 2023
spoo-bar
left a comment
spoo-bar
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good. Couple small changes in code organization.
Havent gone through the tests yet.
Codecov ReportBase: 69.52% // Head: 69.88% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 69.52% 69.88% +0.35%
==========================================
Files 61 61
Lines 3636 3692 +56
==========================================
+ Hits 2528 2580 +52
- Misses 1033 1038 +5
+ Partials 75 74 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
Author
|
@fdymylja Gentle reminder for review ^ |
fdymylja
suggested changes
Feb 14, 2023
fdymylja
left a comment
fdymylja
left a comment
Contributor
There was a problem hiding this comment.
Just a small nit and it should be good to go.
fdymylja
dismissed
spoo-bar’s stale review
dismissing because the concerns were addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #269
genesis.prototo include flat fees data for contracts