Skip to content

feat(wasmbindings): update metadata of a different contract#326

Merged
aelesbao merged 2 commits into
archway-network:mainfrom
chris-ricketts:feat/contract-to-contract-update-meta
Mar 28, 2023
Merged

feat(wasmbindings): update metadata of a different contract#326
aelesbao merged 2 commits into
archway-network:mainfrom
chris-ricketts:feat/contract-to-contract-update-meta

Conversation

@chris-ricketts

Copy link
Copy Markdown
Contributor

Allows a contract A to update the rewards metadata of contract B, if contract A's address matches the OwnerAddress of contract B.

Closes #321

@codecov

codecov Bot commented Mar 23, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.07 🎉

Comparison is base (6fceed8) 69.55% compared to head (9eaa514) 69.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   69.55%   69.63%   +0.07%     
==========================================
  Files          63       63              
  Lines        3758     3777      +19     
==========================================
+ Hits         2614     2630      +16     
- Misses       1068     1070       +2     
- Partials       76       77       +1     
Impacted Files Coverage Δ
wasmbinding/rewards/types/msg_metadata.go 50.94% <76.92%> (+8.44%) ⬆️
wasmbinding/rewards/msg_handler.go 87.50% <100.00%> (+1.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aelesbao aelesbao requested review from aelesbao, fdymylja and spoo-bar and removed request for fdymylja and spoo-bar March 24, 2023 14:16
@chris-ricketts

chris-ricketts commented Mar 27, 2023

Copy link
Copy Markdown
Contributor Author

@aelesbao fixed merge conflict that came up with 6fceed8

Latest forced-push contains newly built contracts/go/voter/code.wasm that satisfies @fdymylja's new tests and the tests added in this PR.

I'm afraid the 1 failing check on this PR is out of my control.

@aelesbao

Copy link
Copy Markdown
Contributor

@chris-ricketts thanks for the update. The Docker build will fail in your fork because it doesn't have the credentials for Docker Hub, which is fine.

@aelesbao aelesbao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a small style change to the handler, but it LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(wasmbindings): Allow a contract to update another contract's metadata via wasmbindings

2 participants