Skip to content

feat(x/rewards): Disallow setting module accounts as reward addresses#356

Merged
fdymylja merged 6 commits into
mainfrom
fdymylja/disallow-module-reward-addr
May 8, 2023
Merged

feat(x/rewards): Disallow setting module accounts as reward addresses#356
fdymylja merged 6 commits into
mainfrom
fdymylja/disallow-module-reward-addr

Conversation

@fdymylja

@fdymylja fdymylja commented May 8, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented May 8, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 81.25% and project coverage change: +0.04 🎉

Comparison is base (92abf73) 69.39% compared to head (15e80bf) 69.44%.

❗ Current head 15e80bf differs from pull request most recent head efcc433. Consider uploading reports for the commit efcc433 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
+ Coverage   69.39%   69.44%   +0.04%     
==========================================
  Files          65       65              
  Lines        3843     3858      +15     
==========================================
+ Hits         2667     2679      +12     
- Misses       1090     1092       +2     
- Partials       86       87       +1     
Impacted Files Coverage Δ
x/rewards/keeper/keeper.go 90.90% <ø> (ø)
x/rewards/keeper/metadata.go 94.91% <80.00%> (-5.09%) ⬇️
app/app.go 90.65% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fdymylja fdymylja merged commit c87b209 into main May 8, 2023
@fdymylja fdymylja deleted the fdymylja/disallow-module-reward-addr branch May 8, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants