Skip to content

refactor!: bumping the proto versions for x/rewards and x/tracking from v1beta1 to v1#357

Merged
spoo-bar merged 11 commits into
mainfrom
spoorthi/290-proto-to-v1
May 9, 2023
Merged

refactor!: bumping the proto versions for x/rewards and x/tracking from v1beta1 to v1#357
spoo-bar merged 11 commits into
mainfrom
spoorthi/290-proto-to-v1

Conversation

@spoo-bar

@spoo-bar spoo-bar commented May 8, 2023

Copy link
Copy Markdown
Contributor

❗BREAKING CHANGE

Closes: #290

  • Updates the proto package path from v1beta1 to v1 for the x/rewards and x/tracking module
  • Updates the relevant docs references
  • Updates the voter contract binary to refer to the new proto paths

@spoo-bar spoo-bar changed the title refactor!: bumping the proto versions for x/rewards and x/tracking from v1beta1 to v1 BREAKING CHANGE: bumping the proto versions for x/rewards and x/tracking from v1beta1 to v1 May 8, 2023
@codecov

codecov Bot commented May 8, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (c87b209) 69.44% compared to head (0f58ec2) 69.44%.

❗ Current head 0f58ec2 differs from pull request most recent head e73adb3. Consider uploading reports for the commit e73adb3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   69.44%   69.44%           
=======================================
  Files          65       65           
  Lines        3858     3858           
=======================================
  Hits         2679     2679           
  Misses       1092     1092           
  Partials       87       87           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@spoo-bar spoo-bar changed the title BREAKING CHANGE: bumping the proto versions for x/rewards and x/tracking from v1beta1 to v1 refactor!: bumping the proto versions for x/rewards and x/tracking from v1beta1 to v1 May 8, 2023
@spoo-bar spoo-bar requested review from aelesbao and fdymylja May 8, 2023 15:22
@spoo-bar spoo-bar marked this pull request as ready for review May 8, 2023 15:22

@fdymylja fdymylja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@spoo-bar spoo-bar merged commit 2a7aee9 into main May 9, 2023
@spoo-bar spoo-bar deleted the spoorthi/290-proto-to-v1 branch May 9, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API BREAKING]: bump rewards and tracking protos to v1.

3 participants