Skip to content

fix: fix DefaultPowerReduction to accomodate high precision networks#382

Merged
aelesbao merged 8 commits into
mainfrom
fdymylja/fix-default-cons-power
May 15, 2023
Merged

fix: fix DefaultPowerReduction to accomodate high precision networks#382
aelesbao merged 8 commits into
mainfrom
fdymylja/fix-default-cons-power

Conversation

@fdymylja

Copy link
Copy Markdown
Contributor

No description provided.

@fdymylja fdymylja requested review from a team and loverdos May 13, 2023 04:51
@codecov

codecov Bot commented May 13, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.03 🎉

Comparison is base (2a7aee9) 69.44% compared to head (3740b7f) 69.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
+ Coverage   69.44%   69.47%   +0.03%     
==========================================
  Files          65       65              
  Lines        3858     3862       +4     
==========================================
+ Hits         2679     2683       +4     
  Misses       1092     1092              
  Partials       87       87              
Impacted Files Coverage Δ
app/app_upgrades.go 61.90% <ø> (ø)
x/rewards/keeper/min_cons_fee.go 69.23% <0.00%> (ø)
app/app.go 90.72% <100.00%> (+0.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zanicar zanicar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than 2 lint issues on go imports - LGTM;

@zanicar zanicar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanicar zanicar self-requested a review May 15, 2023 07:04

@zanicar zanicar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aelesbao aelesbao merged commit ed01faf into main May 15, 2023
@aelesbao aelesbao deleted the fdymylja/fix-default-cons-power branch May 15, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants