Skip to content

feat: add genmsg module#387

Merged
zanicar merged 11 commits into
mainfrom
fdymylja/genesis_messages
May 22, 2023
Merged

feat: add genmsg module#387
zanicar merged 11 commits into
mainfrom
fdymylja/genesis_messages

Conversation

@fdymylja

Copy link
Copy Markdown
Contributor

No description provided.

@fdymylja fdymylja requested review from a team and spoo-bar May 19, 2023 13:19
Comment thread go.mod
@codecov

codecov Bot commented May 19, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 60.21% and project coverage change: -0.19 ⚠️

Comparison is base (a10d67a) 69.47% compared to head (4dc1d59) 69.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
- Coverage   69.47%   69.29%   -0.19%     
==========================================
  Files          65       67       +2     
  Lines        3863     3954      +91     
==========================================
+ Hits         2684     2740      +56     
- Misses       1092     1119      +27     
- Partials       87       95       +8     
Impacted Files Coverage Δ
app/test_helpers.go 0.62% <0.00%> (ø)
x/rewards/keeper/keeper.go 90.90% <ø> (ø)
x/genmsg/module.go 47.36% <47.36%> (ø)
x/genmsg/genesis.go 69.38% <69.38%> (ø)
app/app.go 90.81% <100.00%> (+0.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zanicar zanicar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the lint issues: LGTM

@zanicar zanicar self-requested a review May 22, 2023 12:32

@zanicar zanicar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanicar zanicar merged commit 28ad6f6 into main May 22, 2023
@zanicar zanicar deleted the fdymylja/genesis_messages branch May 22, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants