Skip to content

fix: Remove genesis module msg logging#408

Merged
zanicar merged 2 commits into
mainfrom
zanicar/rc3
Jun 22, 2023
Merged

fix: Remove genesis module msg logging#408
zanicar merged 2 commits into
mainfrom
zanicar/rc3

Conversation

@zanicar

@zanicar zanicar commented Jun 22, 2023

Copy link
Copy Markdown
Contributor

Message logging may significantly impact network start up performance due to excessive terminal output;

@zanicar zanicar marked this pull request as ready for review June 22, 2023 10:09
@zanicar zanicar requested review from a team and fdymylja June 22, 2023 10:09
@codecov

codecov Bot commented Jun 22, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (8aba65c) 69.34% compared to head (b273cc2) 69.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   69.34%   69.33%   -0.01%     
==========================================
  Files          67       67              
  Lines        3980     3979       -1     
==========================================
- Hits         2760     2759       -1     
  Misses       1124     1124              
  Partials       96       96              
Impacted Files Coverage Δ
x/genmsg/genesis.go 68.75% <100.00%> (-0.64%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@loverdos loverdos left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanicar zanicar merged commit 1673536 into main Jun 22, 2023
@zanicar zanicar deleted the zanicar/rc3 branch June 22, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants