feat(x/rewards): Add fee burn#422
Merged
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
==========================================
- Coverage 69.59% 69.54% -0.05%
==========================================
Files 67 67
Lines 4002 4006 +4
==========================================
+ Hits 2785 2786 +1
- Misses 1122 1124 +2
- Partials 95 96 +1
☔ View full report in Codecov by Sentry. |
spoo-bar
reviewed
Jul 24, 2023
Signed-off-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>
spoo-bar
approved these changes
Jul 26, 2023
spoo-bar
left a comment
spoo-bar
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
We should also update ADR about this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds fee burning on TX fees which are not distributed to contracts.