fix: upgrade handler missing burn permissions for feecollector account#437
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
==========================================
- Coverage 69.54% 69.52% -0.03%
==========================================
Files 67 68 +1
Lines 4006 4023 +17
==========================================
+ Hits 2786 2797 +11
- Misses 1124 1128 +4
- Partials 96 98 +2
☔ View full report in Codecov by Sentry. |
spoo-bar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #438
TestFeeCollectorBurnChainUpgrade- This test starts a chain with v2.0.0, upgrades it to v4.0.0 and then upgrades it to v4.0.1 and then checks if the fee collector account has burn permissions