docs: ADR-008 – Improvements on rewards withdrawal experience.#462
Merged
Conversation
aelesbao
approved these changes
Sep 27, 2023
Contributor
|
I have only one doubt: should the default behavior be the direct distribution to the wallets, so the developer has the |
Contributor
This will invert the current behavior... thus, the suggested approach maintains the current status quo and adds the optional direct withdrawal without affecting any existing deployments; From the tooling, or CLI perspective, we can utilize direct withdrawal as default behavior by always setting the flag, effectively treating rewards records as an opt-in mechanism; |
spoo-bar
approved these changes
Sep 28, 2023
Signed-off-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>
spoo-bar
approved these changes
Nov 30, 2023
zanicar
approved these changes
Nov 30, 2023
spoo-bar
added a commit
that referenced
this pull request
Jan 22, 2024
* add withdrawal ux improvements adr * Update ADR-008-withdrawal-ux-improvements.md Signed-off-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com> * Update CHANGELOG.md --------- Signed-off-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com> Co-authored-by: Spoorthi Satheesha <9302666+spoo-bar@users.noreply.github.com>
spoo-bar
added a commit
that referenced
this pull request
Jan 23, 2024
* refactor(x/rewards): move state to use collections (#475) * state works in a backwards compatible manner * migrate contract metadata to use collections * move params in a backwards compatible way * move params to use collections * flat fees moved in backwards compatible way * move flat fees fully to use collections * flat fee keys cleanup * move min cons fee in a non state breaking way * move min cons fee to use collections fully * cleanup keys.go * move blockrewards to collections in a state compatible way * move genesis to use collections * move more code to use collections * remove more code * move DeleteBLockRewardsCascade from State to Keeper * move tx rewards to collections in a safe way * more of TxRewards state moved to collections * fully migrate TxRewards to collections * checkpoint * remove GetRewardsByRewardAddr in state_rewards_record.go * remove CreateRewardsRecord in state_rewards_record.go * remove more from state_rewards_record.go * tmp commit * remove all unneeded things * finalise fast removal * fix prefix and cleanup * lint fully + CHANGELOG.md * address nits * feat(rewards): enhance withdrawal of rewards developer experience (#502) * add proto files and backwards compat test * add changes + tests to distribution * lint * CHANGELOG.md --------- Signed-off-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com> * docs: ADR-008 – Improvements on rewards withdrawal experience. (#462) * add withdrawal ux improvements adr * Update ADR-008-withdrawal-ux-improvements.md Signed-off-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com> * Update CHANGELOG.md --------- Signed-off-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com> Co-authored-by: Spoorthi Satheesha <9302666+spoo-bar@users.noreply.github.com> * running swagger gen --------- Signed-off-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com> Co-authored-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes changes to the rewards module to address UX problems on the rewards withdrawal mechanism.
Rendered: https://github.com/archway-network/archway/blob/2930de0a144170db8c76a1ac0d845a73ceceec25/docs/adr/ADR-008-withdrawal-ux-improvements.md