fix: amd64 binary compatibility on newer linux distributions#476
Merged
Conversation
jlehtimaki
force-pushed
the
fix-amd64-binary-compatibility
branch
from
6437d26 to
9e751a1
Compare
jlehtimaki
changed the title
zanicar
approved these changes
Oct 20, 2023
this is to have consistent naming scheme in the workflows
to have more consistent naming scheme between the checksums
kayano
reviewed
Oct 27, 2023
replaced RELEASE with GORELEASER_SHIP_VALIDATE
zanicar
approved these changes
Oct 27, 2023
kayano
approved these changes
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes to fix issues when running
archwaydamd64binary on newer linux releases thanUbuntu 20.04:amd64builds. This solves the compatibility issues with the binary when it's natively built onamd64architecture.goreleaser-crossto build for every other OS / ARCH that Archway supports. It also handles the docker manifest deployments, where it needs to useinsecureto flags since theamd64are built on another workflow step.deploy.yamlworkflow to more descriptivedev-build.yamlgoreleaserandgoreleaser-crossto useghcr.ioimages instead of dockerhub onesThis workflow was tested on my fork and you can check the results there:
https://github.com/jlehtimaki/archway/releases
https://github.com/jlehtimaki?tab=packages&repo_name=archway