Skip to content

fix(app): rest endpoints#496

Merged
spoo-bar merged 3 commits into
mainfrom
fd/fix_rest
Nov 2, 2023
Merged

fix(app): rest endpoints#496
spoo-bar merged 3 commits into
mainfrom
fd/fix_rest

Conversation

@fdymylja

@fdymylja fdymylja commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

this brings back rest endpoints in the app

@fdymylja fdymylja requested review from a team and spoo-bar November 2, 2023 16:41
@codecov

codecov Bot commented Nov 2, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ffde5eb) 69.28% compared to head (d6905f0) 69.38%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
+ Coverage   69.28%   69.38%   +0.10%     
==========================================
  Files          70       70              
  Lines        4145     4139       -6     
==========================================
  Hits         2872     2872              
+ Misses       1169     1163       -6     
  Partials      104      104              
Files Coverage Δ
app/app_upgrades.go 61.90% <ø> (ø)
app/app.go 91.42% <0.00%> (+0.83%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zanicar zanicar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint issues...

@spoo-bar spoo-bar merged commit 3b382eb into main Nov 2, 2023
@spoo-bar spoo-bar deleted the fd/fix_rest branch November 2, 2023 17:30
spoo-bar added a commit that referenced this pull request Nov 2, 2023
* fix rest

* CHANGELOG.md

* lint fix

---------

Co-authored-by: Spoorthi Satheesha <9302666+spoo-bar@users.noreply.github.com>
@spoo-bar spoo-bar mentioned this pull request Nov 2, 2023
spoo-bar added a commit that referenced this pull request Nov 2, 2023
* fix(app): rest endpoints (#496)

* fix rest

* CHANGELOG.md

* lint fix

---------

Co-authored-by: Spoorthi Satheesha <9302666+spoo-bar@users.noreply.github.com>

* Update CHANGELOG.md

---------

Co-authored-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants