feat: implement x/callback module by spoo-bar · Pull Request #501 · archway-network/archway

spoo-bar · 2023-11-08T10:16:55Z

Closes: #479

RFC: https://github.com/orgs/archway-network/discussions/25
AIP: #477

The implementation spec can be found under x/callback/spec

* adding proto for callback * generating proto types

* adding callback module skeleton * lint fix

* adding params types * adding params test * adding param keeper get and set * fix lint

codecov · 2023-11-08T10:29:58Z

Codecov Report

Attention: 258 lines in your changes are missing coverage. Please review.

Comparison is base (8c8b7e0) 65.90% compared to head (d6ffa88) 65.61%.

Files	Patch %	Lines
x/callback/types/msg.go	0.00%	55 Missing ⚠️
x/callback/types/events.go	0.00%	39 Missing ⚠️
x/callback/keeper/msg_server.go	72.07%	28 Missing and 3 partials ⚠️
x/callback/types/callback.go	30.55%	21 Missing and 4 partials ⚠️
x/callback/keeper/callback.go	80.85%	12 Missing and 6 partials ⚠️
x/callback/keeper/grpc_query.go	68.00%	15 Missing and 1 partial ⚠️
x/callback/module.go	65.21%	16 Missing ⚠️
x/callback/keeper/fees.go	64.70%	8 Missing and 4 partials ⚠️
x/callback/types/genesis.go	42.85%	12 Missing ⚠️
x/callback/keeper/keeper.go	79.16%	7 Missing and 3 partials ⚠️
... and 4 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   65.90%   65.61%   -0.30%     
==========================================
  Files          64       80      +16     
  Lines        3916     4633     +717     
==========================================
+ Hits         2581     3040     +459     
- Misses       1207     1436     +229     
- Partials      128      157      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

using collections for params

* adding callback state keepers * updating block height stuff to use int64 instead of uint64 * cleanup * adding type validation * using collections * fixing the collection stuff * storing collection schema in keeper --------- Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com>

* params() * callbacks() * using dec coin instead of coin * estimateCallbackFees() * linting * refactor the estimate fees endpoint * linting * adding review comments

* adding update params * request callback * merge updates * fixing callback proto * using only native denom for stuff * handling fees when requesting callback * linting * custom error * addressing pr review comments * do auth stuff before token transfer --------- Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com>

* executing callbacks in endblocker * adding docs * cleanup * pleasing the linter gods * adding test for callbackmsg string marshal * linter. i hate you * addressing pr review comments * addressing pr review comments

* adding cli query params * adding cli query estimate-callback-fees & callbacks * implementing sdk.Msg interface * adding cli tx request-callback & cancel-callback * lint fixes

* removing callbacks from genesis state * implementing base genesis * implement init and export genesis * exporting callbacks in genesis * exporting callbacks in genesis * linting

* adding helper methods for x/bank * returning fees in cancel callback * handling fees post callback execution * pr review comments addressing

* creating event types * adding event emit helpers * emitting events * fixing merge --------- Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com>

* implementing callback module app wiring * adding to upgrade handler * linting * registering msg codecs

* adding callback types test * adding genesis types test * adding SaveCallback tests * adding DeleteCallback tests * adding RequestCallback tests * adding CancelCallback tests * linting * fixing issue when could not save callbacks * adding callback-test * adding tests for abci * adding TestGetCallbacksByHeight * adding TestGetAllCallbacks * adding TestIterateCallbacksByHeight * adding TestCallbacks * implementing TestEstimateCallbackFees * fixing issue with out of gas error txfee refund handling * fixing linting * cleanup * cleanup the test contract * fixing issue with callback params not being considered * linting 😶‍🌫️

* Create LICENSE * adding spec boilerplate * Update README.md * Update 01_state.md * Update 02_messages.md * Update 03_end_block.md * Update 04_events.md * Update 06_wasm_bindings.md * Update 05_client.md * typo fixes * Update CHANGELOG.md

zanicar

Some minor nitpicks and typos that need to be addressed...

zanicar

LGTM

fdymylja

LGTM! :D

Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com>

spoo-bar added 4 commits November 2, 2023 12:08

feat: adding x/callback module proto files (#480)

c1e1e60

* adding proto for callback * generating proto types

feat(x/callback): Adding module skeleton (#495)

e5ae961

* adding callback module skeleton * lint fix

feat(x/callback): Implement the storage and validation of params (#498)

4a57254

* adding params types * adding params test * adding param keeper get and set * fix lint

Merge branch 'main' into feat/callback-module

591543f

spoo-bar added 15 commits November 9, 2023 11:38

refactor: using collections for params (#503)

7c47b4a

using collections for params

feat(x/callback): Implementing Query Server (#509)

a75e1e2

* params() * callbacks() * using dec coin instead of coin * estimateCallbackFees() * linting * refactor the estimate fees endpoint * linting * adding review comments

Merge branch 'main' into feat/callback-module

e12a8a1

feat(x/callback): Implement the callback execution (#508)

f8f26bb

* executing callbacks in endblocker * adding docs * cleanup * pleasing the linter gods * adding test for callbackmsg string marshal * linter. i hate you * addressing pr review comments * addressing pr review comments

feat: Implementing query and tx CLI (#516)

8fcb507

* adding cli query params * adding cli query estimate-callback-fees & callbacks * implementing sdk.Msg interface * adding cli tx request-callback & cancel-callback * lint fixes

feat: Implement genesis methods (#515)

4b1ebf7

* removing callbacks from genesis state * implementing base genesis * implement init and export genesis * exporting callbacks in genesis * exporting callbacks in genesis * linting

Merge branch 'main' into feat/callback-module

3ccac44

feat(x/callback): Handle fees (#518)

15d1314

* adding helper methods for x/bank * returning fees in cancel callback * handling fees post callback execution * pr review comments addressing

feat(x/callback): throw events (#520)

624f531

* creating event types * adding event emit helpers * emitting events * fixing merge --------- Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com>

feat(x/callback): do app wiring (#519)

591dfb1

* implementing callback module app wiring * adding to upgrade handler * linting * registering msg codecs

docs(x/callback): adding module specs (#526)

dcb610f

* Create LICENSE * adding spec boilerplate * Update README.md * Update 01_state.md * Update 02_messages.md * Update 03_end_block.md * Update 04_events.md * Update 06_wasm_bindings.md * Update 05_client.md * typo fixes * Update CHANGELOG.md

Merge branch 'main' into feat/callback-module

dd2b18f

spoo-bar marked this pull request as ready for review January 2, 2024 11:58

spoo-bar requested review from a team and aelesbao January 2, 2024 11:58

spoo-bar added 2 commits January 2, 2024 15:32

changing the typed event for callback success and failure

7263067

updating swagger file

cd578ea

spoo-bar requested review from fdymylja and zanicar January 3, 2024 11:14

zanicar reviewed Jan 4, 2024

View reviewed changes

Comment thread contracts/callback-test/LICENSE Outdated

zanicar reviewed Jan 4, 2024

View reviewed changes

Comment thread x/callback/LICENSE Outdated

zanicar reviewed Jan 4, 2024

View reviewed changes

Comment thread x/callback/keeper/fees.go Outdated

zanicar suggested changes Jan 4, 2024

View reviewed changes

pr review addressing

5068878

spoo-bar requested a review from zanicar January 4, 2024 14:05

zanicar approved these changes Jan 4, 2024

View reviewed changes

fdymylja approved these changes Jan 9, 2024

View reviewed changes

Merge branch 'main' into feat/callback-module

d6ffa88

Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com>

fdymylja self-requested a review January 9, 2024 17:08

fdymylja approved these changes Jan 9, 2024

View reviewed changes

spoo-bar merged commit 5d3bf97 into main Jan 9, 2024

spoo-bar deleted the feat/callback-module branch January 9, 2024 17:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement x/callback module#501

feat: implement x/callback module#501
spoo-bar merged 23 commits into
mainfrom
feat/callback-module

spoo-bar commented Nov 8, 2023 •

edited

Loading

Uh oh!

codecov Bot commented Nov 8, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zanicar left a comment

Uh oh!

zanicar left a comment

Uh oh!

fdymylja left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

spoo-bar commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zanicar left a comment

Choose a reason for hiding this comment

Uh oh!

zanicar left a comment

Choose a reason for hiding this comment

Uh oh!

fdymylja left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

spoo-bar commented Nov 8, 2023 •

edited

Loading

codecov Bot commented Nov 8, 2023 •

edited

Loading