fix: snapshot db remove hardcoding #514
Merged
Merged
Conversation
spoo-bar
commented
Nov 30, 2023
spoo-bar
commented
Contributor
- Fix snapshot db being hardcoded from goleveldb to based on config
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
=======================================
Coverage 66.02% 66.02%
=======================================
Files 63 63
Lines 3909 3909
=======================================
Hits 2581 2581
Misses 1200 1200
Partials 128 128 ☔ View full report in Codecov by Sentry. |
zanicar
approved these changes
Nov 30, 2023
spoo-bar
added a commit
that referenced
this pull request
Dec 4, 2023
* removing hardcode of snapshot db backend * Update CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.