feat(cwgrants): Implement x/cwgrants module#527
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
==========================================
- Coverage 65.61% 64.50% -1.12%
==========================================
Files 80 88 +8
Lines 4633 4851 +218
==========================================
+ Hits 3040 3129 +89
- Misses 1436 1556 +120
- Partials 157 166 +9 ☔ View full report in Codecov by Sentry. |
# Conflicts: # CHANGELOG.md # app/app.go # app/keepers/keepers.go # app/upgrades/latest/upgrades.go
| // SudoMsg defines the message sudo enum that is sent to the CosmWasm contract. | ||
| type SudoMsg struct { | ||
| // CWGrant defines the enum variant of the grant message. | ||
| CWGrant *CWGrant `json:"cw_grant"` |
There was a problem hiding this comment.
I think CWGrant is fine here, whilst the "module name" is CWFees (as it handles fees); what is being sent as request here is a request for a fee grant.
The name is kept as short as possible to avoid extra gas consumption when we traverse the wasm boundary.
zanicar
left a comment
zanicar
left a comment
There was a problem hiding this comment.
Are we going to change CWGrant to CWFees or are we leaving that for the remediation / refactor cycle? LMKWYT
|
@zanicar I would propose we keep as is, and consider renaming this cwfeegrants, to be in line with cosmos sdk's fee grant module, at nomenclature level, I will create an issue. |
# Conflicts: # CHANGELOG.md
3 participants
No description provided.