Skip to content

ci: fixing interchaintest issue with rc tags#538

Merged
spoo-bar merged 6 commits into
mainfrom
spoorthi/fix-interchaintest-gh-workflow
Jan 26, 2024
Merged

ci: fixing interchaintest issue with rc tags#538
spoo-bar merged 6 commits into
mainfrom
spoorthi/fix-interchaintest-gh-workflow

Conversation

@spoo-bar

@spoo-bar spoo-bar commented Jan 26, 2024

Copy link
Copy Markdown
Contributor

The previous gh action used did not detect release candidate tags. Which would cause issues in PRs.
Replacing with a better one.

@codecov

codecov Bot commented Jan 26, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f72e5a) 64.50% compared to head (8b575c6) 64.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #538   +/-   ##
=======================================
  Coverage   64.50%   64.50%           
=======================================
  Files          88       88           
  Lines        4851     4851           
=======================================
  Hits         3129     3129           
  Misses       1556     1556           
  Partials      166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spoo-bar spoo-bar marked this pull request as ready for review January 26, 2024 12:25
@spoo-bar spoo-bar requested review from a team, aelesbao and philabsbot January 26, 2024 12:25

@shahbazn shahbazn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fdymylja fdymylja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

free main

@spoo-bar spoo-bar merged commit 63038c4 into main Jan 26, 2024
@spoo-bar spoo-bar deleted the spoorthi/fix-interchaintest-gh-workflow branch January 26, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants