feat: adding x/cwica module#542
Merged
Merged
Conversation
…tion id by contract
…rchway-network/archway into spoorthi/adding-ica-controller
zanicar
reviewed
Mar 4, 2024
| return nil | ||
| } | ||
|
|
||
| // // HandleChanCloseConfirm passes the data about a successfully closed channel to the appropriate contract |
Contributor
There was a problem hiding this comment.
Won't we need this for closing and re-opening stale channels (i.e. when they timeout)?
Contributor
Author
There was a problem hiding this comment.
for packet timeout, the channel can be reopened with the HandleChanOpen, so this isnt necessary.
shahbazn
approved these changes
Mar 11, 2024
shahbazn
left a comment
shahbazn
left a comment
Contributor
There was a problem hiding this comment.
only reviewed .github/workflows/interchaintest.yaml
looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x/cwica module enables Cosmwasm based smart contracts to register ICA accounts and send transactions to be executed on counterparty chains
The module spec can be found in: x/cwica/spec