Skip to content

feat: integrate cwerrors into cwica module#549

Merged
spoo-bar merged 20 commits into
mainfrom
spoorthi/error-ica-integration
Apr 3, 2024
Merged

feat: integrate cwerrors into cwica module#549
spoo-bar merged 20 commits into
mainfrom
spoorthi/error-ica-integration

Conversation

@spoo-bar

Copy link
Copy Markdown
Contributor

No description provided.

@spoo-bar spoo-bar marked this pull request as ready for review March 28, 2024 13:34
@spoo-bar spoo-bar requested review from a team and aelesbao March 28, 2024 13:34
@codecov

codecov Bot commented Mar 28, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 55.00000% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 64.56%. Comparing base (3760a7e) to head (e859283).
Report is 1 commits behind head on main.

Files Patch % Lines
x/cwerrors/types/sudo_msg.go 0.00% 11 Missing ⚠️
x/cwica/types/errors.go 0.00% 8 Missing ⚠️
x/cwica/keeper/ibc_handlers.go 63.63% 4 Missing ⚠️
x/cwerrors/keeper/sudo_errors.go 40.00% 2 Missing and 1 partial ⚠️
x/callback/types/errors.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
- Coverage   64.61%   64.56%   -0.05%     
==========================================
  Files         119      120       +1     
  Lines        5969     5975       +6     
==========================================
+ Hits         3857     3858       +1     
- Misses       1897     1901       +4     
- Partials      215      216       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spoo-bar spoo-bar requested review from fdymylja and zanicar March 29, 2024 06:00

@zanicar zanicar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fdymylja fdymylja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@spoo-bar spoo-bar merged commit a03ff86 into main Apr 3, 2024
@spoo-bar spoo-bar deleted the spoorthi/error-ica-integration branch April 3, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants