Skip to content

feat: integrate cwerrors into callback module#550

Merged
spoo-bar merged 3 commits into
mainfrom
spoorthi/callback-ica-integration
Mar 27, 2024
Merged

feat: integrate cwerrors into callback module#550
spoo-bar merged 3 commits into
mainfrom
spoorthi/callback-ica-integration

Conversation

@spoo-bar

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Mar 26, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 56.66667% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 64.61%. Comparing base (9ae0d64) to head (b236cae).

Files Patch % Lines
x/callback/types/errors.go 0.00% 8 Missing ⚠️
x/callback/abci.go 72.22% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   64.72%   64.61%   -0.11%     
==========================================
  Files         118      119       +1     
  Lines        5950     5969      +19     
==========================================
+ Hits         3851     3857       +6     
- Misses       1886     1897      +11     
- Partials      213      215       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spoo-bar spoo-bar marked this pull request as ready for review March 27, 2024 08:48
@spoo-bar spoo-bar requested review from a team and fdymylja March 27, 2024 08:48

@fdymylja fdymylja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat, love it!

@spoo-bar spoo-bar merged commit 3760a7e into main Mar 27, 2024
@spoo-bar spoo-bar deleted the spoorthi/callback-ica-integration branch March 27, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants