Skip to content

NeoPool fix possible IntegerDivideByZero #24578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arendst merged 1 commit into from
Mar 23, 2026
+3 −2
Merged

NeoPool fix possible IntegerDivideByZero #24578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ All notable changes to this project will be documented in this file.
### Fixed
- Athom esp32 2-3-4 gang change led behaviour after firmware update (#24509)
- ESP8266 heap drain and exception 29 when DHCP provides NTP server (#24515)
- NeoPool fix possible IntegerDivideByZero

### Removed
- Berry removed `BE_USE_PRECOMPILED_OBJECT` which is enforced in Tasmota (#24565)
Expand Down
4 changes: 2 additions & 2 deletions tasmota/tasmota_xsns_sensor/xsns_83_neopool.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2173,8 +2173,8 @@ void NeoPoolShow(bool json)
ResponseAppend_P(PSTR(",\"" D_NEOPOOL_JSON_MAX "\":" NEOPOOL_FMT_HIDRO), decimals, &fvalue);

ResponseAppend_P(PSTR(",\"" D_NEOPOOL_JSON_PERCENT "\":{"));
ResponseAppend_P(PSTR( "\"" D_JSON_DATA "\":%d"), data * 100 / max);
ResponseAppend_P(PSTR(",\"" D_NEOPOOL_JSON_SETPOINT "\":%d"), setpoint * 100 / max);
ResponseAppend_P(PSTR( "\"" D_JSON_DATA "\":%d"), max ? (data * 100 / max) : 0);
ResponseAppend_P(PSTR(",\"" D_NEOPOOL_JSON_SETPOINT "\":%d"), max ? (setpoint * 100 / max) : 0);
ResponseJsonEnd();

ResponseAppend_P(PSTR(",\"" D_NEOPOOL_JSON_CELL_RUNTIME "\":{"));
Expand Down
Loading
⚡