-
Notifications
You must be signed in to change notification settings - Fork 2.1k
redis-ha sub-chart does not inherit global.nodeSelector #3807
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Is your feature request related to a problem?
I noticed that global.nodeSelector does not propagate to redis-ha when templating.
helm template argo-cd oci://ghcr.io/argoproj/argo-helm/argo-cd --version 9.4.16 --set global.nodeSelector.node-group=system --set redis-ha.enabled=true > manifest-global.yaml# manifest-global.yaml
kind: Deployment
apiVersion: apps/v1
metadata:
name: argo-cd-redis-ha-haproxy
spec:
template:
spec:
nodeSelector:
{}Related helm chart
argo-cd
Describe the solution you'd like
global.nodeSelector should propagate down to the redis-ha sub-chart's nodeSelector.
Describe alternatives you've considered
As a workaround, I had to manually specify the nodeSelector in redis-ha.
helm template argo-cd oci://ghcr.io/argoproj/argo-helm/argo-cd --version 9.4.16 --set redis-ha.nodeSelector.node-group=system --set redis-ha.enabled=true > manifest-explicit.yaml# manifest-explicit.yaml
kind: Deployment
apiVersion: apps/v1
metadata:
name: argo-cd-redis-ha-haproxy
spec:
template:
spec:
nodeSelector:
node-group: systemAdditional context
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request