Skip to content

redis-ha sub-chart does not inherit global.nodeSelector #3807

@nchengyeeshen

Description

@nchengyeeshen

Is your feature request related to a problem?

I noticed that global.nodeSelector does not propagate to redis-ha when templating.

helm template argo-cd oci://ghcr.io/argoproj/argo-helm/argo-cd --version 9.4.16 --set global.nodeSelector.node-group=system --set redis-ha.enabled=true > manifest-global.yaml
# manifest-global.yaml

kind: Deployment
apiVersion: apps/v1
metadata:
  name: argo-cd-redis-ha-haproxy
spec:
  template:
    spec:
      nodeSelector:
        {}

Related helm chart

argo-cd

Describe the solution you'd like

global.nodeSelector should propagate down to the redis-ha sub-chart's nodeSelector.

Describe alternatives you've considered

As a workaround, I had to manually specify the nodeSelector in redis-ha.

helm template argo-cd oci://ghcr.io/argoproj/argo-helm/argo-cd --version 9.4.16 --set redis-ha.nodeSelector.node-group=system --set redis-ha.enabled=true > manifest-explicit.yaml
# manifest-explicit.yaml

kind: Deployment
apiVersion: apps/v1
metadata:
  name: argo-cd-redis-ha-haproxy
spec:
  template:
    spec:
      nodeSelector:
        node-group: system

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions