fix(controller): add backward compatibility for --metricsport flag#4457
Merged
zachaller merged 2 commits intoargoproj:masterfrom Nov 3, 2025
Merged
Conversation
…ixes argoproj#4428 Add deprecated --metricsport flag alias to maintain backward compatibility with Helm charts while encouraging migration to --metricsPort. - Adds --metricsport as deprecated alias for --metricsPort - Shows deprecation warning when --metricsport is used - Maintains full backward compatibility with existing deployments Signed-off-by: puretension <rlrlfhtm5@gmail.com>
puretension
force-pushed
the
fix/metricsport-backward-compatibility-4428
branch
from
ee58be9 to
9a9361c
Compare
Contributor
Published E2E Test Results 4 files 4 suites 3h 31m 18s ⏱️ For more details on these failures, see this check. Results for commit 3f49948. ♻️ This comment has been updated with latest results. |
Contributor
Published Unit Test Results2 331 tests 2 331 ✅ 3m 1s ⏱️ Results for commit 3f49948. ♻️ This comment has been updated with latest results. |
puretension
changed the title
- Change jsonPath from {$.json} to {$} to get full response
- Update conditions to use result.json.status instead of result.status
- Fixes flaky TestCanaryInconclusiveBackgroundAnalysis e2e test
Signed-off-by: puretension <rlrlfhtm5@gmail.com>
puretension
force-pushed
the
fix/metricsport-backward-compatibility-4428
branch
from
a7c447a to
3f49948
Compare
|
zachaller
approved these changes
Nov 3, 2025
zachaller
approved these changes
Nov 3, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
What this PR does:
Adds backward compatibility for the
--metricsportflag that was changed to--metricsPortin #4368.Why we need it:
The camelCase change broke compatibility with Helm charts that still use
--metricsport. This fix allows both flags to work while encouraging migration to the new format.Testing:
--metricsportand--metricsPortflags manuallyChanges:
--metricsportas deprecated alias for--metricsPort