Skip to content

fix(dashboard): Show page size selector in table view#4629

Open
gheine wants to merge 5 commits intoargoproj:masterfrom
gheine:table-view-page-size-selector
Open

fix(dashboard): Show page size selector in table view#4629
gheine wants to merge 5 commits intoargoproj:masterfrom
gheine:table-view-page-size-selector

Conversation

@gheine
Copy link
Copy Markdown

@gheine gheine commented Feb 24, 2026

Summary

  • Enable the page size selector dropdown in the rollouts table view by adding showSizeChanger: true to the Ant Design Table pagination config
  • Users can now choose between 10, 20, 50, and 100 items per page

Test plan

  • Open the Argo Rollouts dashboard in table view
  • Verify the page size dropdown is visible in the pagination controls
  • Change the page size and verify the table updates accordingly

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Signed-off-by: Gregor Heine <[email protected]>
@gheine gheine force-pushed the table-view-page-size-selector branch from 374eddf to 2adbc52 Compare February 24, 2026 20:09
@gheine gheine changed the title Show page size selector in table view fix(dashboard): Show page size selector in table view Feb 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 24, 2026

Published E2E Test Results

  4 files    4 suites   3h 38m 51s ⏱️
120 tests 110 ✅  7 💤 3 ❌
488 runs  452 ✅ 28 💤 8 ❌

For more details on these failures, see this check.

Results for commit ddb73b1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 24, 2026

Published Unit Test Results

2 443 tests   2 443 ✅  3m 18s ⏱️
  129 suites      0 💤
    1 files        0 ❌

Results for commit ddb73b1.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.84%. Comparing base (e046515) to head (ddb73b1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4629      +/-   ##
==========================================
- Coverage   84.86%   84.84%   -0.03%     
==========================================
  Files         164      164              
  Lines       18954    18954              
==========================================
- Hits        16086    16082       -4     
- Misses       2007     2009       +2     
- Partials      861      863       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant