feat(controller): add --configmap-name flag to override controller ConfigMap#4664
Open
a1exx-k wants to merge 1 commit intoargoproj:masterfrom
Open
feat(controller): add --configmap-name flag to override controller ConfigMap#4664a1exx-k wants to merge 1 commit intoargoproj:masterfrom
a1exx-k wants to merge 1 commit intoargoproj:masterfrom
Conversation
7 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4664 +/- ##
==========================================
+ Coverage 84.86% 84.89% +0.02%
==========================================
Files 164 164
Lines 18954 18961 +7
==========================================
+ Hits 16086 16097 +11
+ Misses 2007 2005 -2
+ Partials 861 859 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Published E2E Test Results 4 files 4 suites 3h 40m 6s ⏱️ For more details on these failures, see this check. Results for commit 89cb569. ♻️ This comment has been updated with latest results. |
Contributor
Published Unit Test Results2 444 tests 2 444 ✅ 3m 18s ⏱️ Results for commit 89cb569. ♻️ This comment has been updated with latest results. |
44710f7 to
404ad5e
Compare
blkperl
approved these changes
Mar 20, 2026
…nfigMap The controller ConfigMap name was hardcoded to "argo-rollouts-config" with no way to override it. This adds a --configmap-name flag so operators can specify an alternative name, which is useful when running multiple controller instances in the same namespace or when the default name conflicts with existing resources. Signed-off-by: Alex Kazantcev <[email protected]> Co-Authored-By: Claude Opus 4.6 <[email protected]>
404ad5e to
89cb569
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
argo-rollouts-configwith no way to override it at runtime--configmap-nameflag to theargo-rollouts-controllerbinary so operators can specify an alternative nameResolves #4665
Changes
cmd/rollouts-controller/main.go: new--configmap-nameflag (default:argo-rollouts-config)controller/controller.go:NewManagerandNewAnalysisManageraccept arolloutsConfigMapName stringparameter, replacing the hardcodeddefaults.DefaultRolloutsConfigMapNameconstant at the call sitescontroller/controller_test.go: updated call sites to passdefaults.DefaultRolloutsConfigMapNameChecklist:
"fix(controller): Updates such and such. Fixes #1234".🤖 Generated with Claude Code