fix(controller): honor stderrthreshold when logtostderr is enabled#4673
Open
pierluigilenoci wants to merge 1 commit intoargoproj:masterfrom
Open
fix(controller): honor stderrthreshold when logtostderr is enabled#4673pierluigilenoci wants to merge 1 commit intoargoproj:masterfrom
pierluigilenoci wants to merge 1 commit intoargoproj:masterfrom
Conversation
Opt into the fixed klog behavior by setting legacy_stderr_threshold_behavior=false after klog.InitFlags(). Ref: kubernetes/klog#212, kubernetes/klog#432 Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com>
Author
|
Hi @dependabot[bot],dthomson25,jessesuen — would you be willing to review? Thank you! |
|
Contributor
Published E2E Test Results 4 files 4 suites 3h 48m 42s ⏱️ For more details on these failures, see this check. Results for commit 011ab41. |
Contributor
Published Unit Test Results2 443 tests 2 443 ✅ 3m 18s ⏱️ Results for commit 011ab41. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4673 +/- ##
==========================================
- Coverage 84.86% 84.83% -0.04%
==========================================
Files 164 164
Lines 18954 18954
==========================================
- Hits 16086 16080 -6
- Misses 2007 2010 +3
- Partials 861 864 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pierluigilenoci
changed the title
pierluigilenoci
changed the title
pierluigilenoci
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opt into the new klog behavior so that
-stderrthresholdis honored even when-logtostderr=true(the default). Setstderrthreshold=INFOto preserve backward compatibility.Background
When
-logtostderr=true,-stderrthresholdwas ignored — all logs went to stderr. Fixed in kubernetes/klog#432 (v2.140.0+), but projects must opt in.References