Skip to content

fix(controller): Handle requeue when getting stale resource version#4674

Open
jonathan-innis wants to merge 1 commit intoargoproj:masterfrom
jonathan-innis:jinnis/stale-requeue-handling
Open

fix(controller): Handle requeue when getting stale resource version#4674
jonathan-innis wants to merge 1 commit intoargoproj:masterfrom
jonathan-innis:jinnis/stale-requeue-handling

Conversation

@jonathan-innis
Copy link
Copy Markdown

@jonathan-innis jonathan-innis commented Mar 27, 2026

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • My builds are green. Try syncing with master if they are not.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • I have run all tests locally (including the flaky ones) and they pass on my workstation
  • I have used LLM/AI/Agent tools for this PR but I am responsible for all code of this PR
  • I understand what the code does and WHY/HOW it works in several scenarios
  • I know if my code is just adding new functionality or changing old functionality for existing users
  • My organization is added to USERS.md.

@jonathan-innis jonathan-innis force-pushed the jinnis/stale-requeue-handling branch 2 times, most recently from c7ace26 to fe81684 Compare March 27, 2026 00:35
@jonathan-innis jonathan-innis changed the title Handle requeue when getting stale resource version fix(controller): Handle requeue when getting stale resource version Mar 27, 2026
@jonathan-innis jonathan-innis force-pushed the jinnis/stale-requeue-handling branch 12 times, most recently from 4e1120e to e5874ae Compare March 27, 2026 01:47
@jonathan-innis jonathan-innis marked this pull request as ready for review March 27, 2026 01:54
@jonathan-innis jonathan-innis force-pushed the jinnis/stale-requeue-handling branch 3 times, most recently from 2c15aa1 to e4c9ff6 Compare March 27, 2026 02:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Published E2E Test Results

  4 files    4 suites   3h 35m 33s ⏱️
120 tests 108 ✅  7 💤 5 ❌
486 runs  452 ✅ 28 💤 6 ❌

For more details on these failures, see this check.

Results for commit facd8ee.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.82%. Comparing base (e046515) to head (facd8ee).

Files with missing lines Patch % Lines
rollout/controller.go 78.94% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4674      +/-   ##
==========================================
- Coverage   84.86%   84.82%   -0.05%     
==========================================
  Files         164      164              
  Lines       18954    18948       -6     
==========================================
- Hits        16086    16072      -14     
- Misses       2007     2011       +4     
- Partials      861      865       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Published Unit Test Results

2 442 tests   2 442 ✅  3m 18s ⏱️
  129 suites      0 💤
    1 files        0 ❌

Results for commit facd8ee.

♻️ This comment has been updated with latest results.

@jonathan-innis jonathan-innis force-pushed the jinnis/stale-requeue-handling branch 2 times, most recently from b1a85a3 to 2c69f13 Compare March 28, 2026 06:34
@jonathan-innis jonathan-innis force-pushed the jinnis/stale-requeue-handling branch from 2c69f13 to facd8ee Compare March 28, 2026 06:50
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant