Skip to content

fix(controller): pre/post analysis support on blue green with autopromotion off. Fixes #4503#4677

Open
zachaller wants to merge 3 commits intoargoproj:masterfrom
zachaller:pr-4540-review
Open

fix(controller): pre/post analysis support on blue green with autopromotion off. Fixes #4503#4677
zachaller wants to merge 3 commits intoargoproj:masterfrom
zachaller:pr-4540-review

Conversation

@zachaller
Copy link
Copy Markdown
Collaborator

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • My builds are green. Try syncing with master if they are not.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • I have run all tests locally (including the flaky ones) and they pass on my workstation
  • I have used LLM/AI/Agent tools for this PR but I am responsible for all code of this PR
  • I understand what the code does and WHY/HOW it works in several scenarios
  • I know if my code is just adding new functionality or changing old functionality for existing users
  • My organization is added to USERS.md.

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.96%. Comparing base (e046515) to head (8b53088).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4677      +/-   ##
==========================================
+ Coverage   84.86%   84.96%   +0.09%     
==========================================
  Files         164      164              
  Lines       18954    18963       +9     
==========================================
+ Hits        16086    16111      +25     
+ Misses       2007     1998       -9     
+ Partials      861      854       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Published E2E Test Results

  4 files    4 suites   3h 57m 2s ⏱️
120 tests 103 ✅  7 💤 10 ❌
502 runs  454 ✅ 28 💤 20 ❌

For more details on these failures, see this check.

Results for commit 8b53088.

@github-actions
Copy link
Copy Markdown
Contributor

Published Unit Test Results

2 449 tests   2 449 ✅  3m 18s ⏱️
  129 suites      0 💤
    1 files        0 ❌

Results for commit 8b53088.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants