fix(controller): decouple workloadRef scaleDown from promoteStable. Fixes #4681#4682
Open
joaquinhuigomez wants to merge 1 commit intoargoproj:masterfrom
Open
Conversation
…ixes argoproj#4681 Move workloadRef scaleDown logic out of promoteStable() into a separate scaleDownWorkloadRef() check that runs after calculateRolloutConditions computes the phase. This fixes two interacting bugs: the initial deploy bypassing PostPromotionAnalysis creating a permanent dead state, and the hardcoded revision==1 guard preventing scaleDown on subsequent revisions. Signed-off-by: Joaquin Hui Gomez <132194176+joaquinhuigomez@users.noreply.github.com>
|
Contributor
Published E2E Test Results 4 files 4 suites 4h 36m 7s ⏱️ For more details on these failures, see this check. Results for commit 07a20a3. |
Contributor
Published Unit Test Results2 443 tests 2 443 ✅ 3m 20s ⏱️ Results for commit 07a20a3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".Moves the workloadRef scaleDown logic out of
promoteStable()into a standalonescaleDownWorkloadRef()that runs aftercalculateRolloutConditionscomputes the phase. This fixes two interacting bugs where blue-green rollouts withpostPromotionAnalysisandworkloadRef.scaleDown: onsuccessnever scale down the referenced Deployment: the initial deploy bypasses PostPromotionAnalysis creating a permanent dead state inshouldFullPromote, and the hardcodedrevision == 1guard prevents scaleDown on any subsequent revision.