fix: Remove client private key from client auth REST config#6506
Merged
alexec merged 1 commit intoargoproj:masterfrom Aug 9, 2021
Merged
fix: Remove client private key from client auth REST config#6506alexec merged 1 commit intoargoproj:masterfrom
alexec merged 1 commit intoargoproj:masterfrom
Conversation
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #6506 +/- ##
==========================================
+ Coverage 48.49% 48.57% +0.07%
==========================================
Files 260 260
Lines 18804 18827 +23
==========================================
+ Hits 9119 9145 +26
+ Misses 8678 8674 -4
- Partials 1007 1008 +1
Continue to review full report at Codecov.
|
sarabala1979
approved these changes
Aug 9, 2021
Member
|
I did the same fix but I am not sure about this is the right way to fix it. I am about to ask tomorrow. |
sarabala1979
pushed a commit
that referenced
this pull request
Aug 12, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
added a commit
that referenced
this pull request
Aug 13, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
added a commit
that referenced
this pull request
Aug 13, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins alex_collins@intuit.com