feat(TeamGitHubLight): add ErrorBoundary on GitHubLight setting card#2082
Closed
feat(TeamGitHubLight): add ErrorBoundary on GitHubLight setting card#2082
Conversation
jsfez
requested review from
a team and
gregberge
and removed request for
a team
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a settings page crash caused by the
Proxy URL is not set error. While that error is valid in the normal backend flow, it should not take down the whole settings page. The GitHub Light card is now isolated behind its own error boundary and GraphQL query, so a failure only affects that card instead of the full page.