Merged
Conversation
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds UI support in the Build diff detail view to download the mask image (and a composited “change with mask” image), adjusting zoom pane controls visibility so controls remain visible while the download menu is open.
Changes:
- Replace the single “download compare screenshot” action with a menu offering: download change, download mask, and download change with mask (canvas compositing).
- Introduce shared download helpers (
fetchBlob,downloadBlob) plus canvas-based mask compositing helpers. - Keep zoom-pane controls visible when a menu button inside the pane is expanded (
aria-expanded=true).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/frontend/src/containers/Build/Zoomer.tsx | Keep zoom controls visible while an internal menu trigger is expanded. |
| apps/frontend/src/containers/Build/BuildDiffDetail.tsx | Add download menu options for mask + composited masked image; add blob/canvas helper functions and toast feedback. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gregberge
force-pushed
the
greg/arg-286-allow-to-download-the-mask
branch
from
00fb949 to
37a8996
Compare
gregberge
force-pushed
the
greg/arg-286-allow-to-download-the-mask
branch
from
37a8996 to
2844283
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.