feat(migration): add migration to update github_pull_requests.id type to bigint#2086
Open
feat(migration): add migration to update github_pull_requests.id type to bigint#2086
Conversation
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
gregberge
requested changes
Apr 2, 2026
| -- PostgreSQL database dump complete | ||
| -- | ||
|
|
||
| \unrestrict 2GIQSmC2cllwgA5SKtS5RhAwQOcUPaKxQ1gBkaPnM6Ir2Gz1OmHj6kk5YsYjXKG |
Contributor
Author
There was a problem hiding this comment.
It's not generated in the dump
| -- PostgreSQL database dump | ||
| -- | ||
|
|
||
| \restrict 2GIQSmC2cllwgA5SKtS5RhAwQOcUPaKxQ1gBkaPnM6Ir2Gz1OmHj6kk5YsYjXKG |
Comment on lines
+2680
to
+2681
| ALTER TABLE ONLY public.users | ||
| ADD CONSTRAINT users_email_unique UNIQUE (email); |
Member
There was a problem hiding this comment.
Weird that it was not present in the structure.
Comment on lines
+2688
to
+2689
| ALTER TABLE ONLY public.users | ||
| ADD CONSTRAINT users_gitlabuserid_unique UNIQUE ("gitlabUserId"); |
Member
There was a problem hiding this comment.
Same for this one but I checked in production and they are present so it's good to have them in the structure.
Comment on lines
+21
to
+23
| await knex.raw( | ||
| "ALTER TABLE github_pull_requests ALTER COLUMN id TYPE BIGINT", | ||
| ); |
Member
There was a problem hiding this comment.
The type seems to be correct in production, so I don't understand the purpose of this PR. If it's in local just fix it.
Contributor
Author
There was a problem hiding this comment.
The prod database is good the migration file is not aligned. So when you apply db:drop + db:create + db:migrate:lastest, there is a drift that break the CI tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.