Conversation
|
It is worth noting that this does not implement CLZ on the SMT, help is welcome on that regard 😄 |
This also bumps the Solidity version used in tests to be able to compile an example with CLZ
|
OK, this should now work, but the ethereum-tests have moved, and have changed format, so that needs to be updated, as per @elopez |
Indentation fix Better indentation
blishko
left a comment
There was a problem hiding this comment.
Nice!
I think it looks good!
I think it would be nice to fix the one misaligned line in the SMT encoding, and add a negative test.
We can also add a concrete test!
There was a problem hiding this comment.
Maybe we should add a negative test as well?
There was a problem hiding this comment.
OK, added more tests, including negative tests. I actually much prefer these to the ones that were added as part of forge, because forge tests are slower and harder to edit. But I'll leave those in, too, they do check forge which is nice.
IIRC the flake.lock change was upgrading the solcs.nix, but I think that might have been upgraded independently since opening this PR. As long as we have a recent enough solc that can do |
|
@msooseth can you remove tests that should pass now from the problematicTests list? It should be at least these, but possibly some other ones as well 😄 https://github.com/argotorg/hevm/blob/17e0724/test/EVM/Test/BlockchainTests.hs#L217-L221 |
|
Damn. Windows is failing, maybe because of the nix "cleanup" I did: |
|
OK, moved Windows to latest solidity. |
Description
This also bumps the Solidity version used in tests to be able to compile an example with CLZ
Checklist