Fix Windows CI update for Postgresql 17#80
Merged
arkhipov merged 1 commit intoarkhipov:pg-17from Jan 12, 2026
Merged
Conversation
Merged
…ion, clean up services, and stabilize test execution
d81bc50 to
7a4eb4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the failures of the Windows Server 2025 x PostgreSQL 14/17 CI tests in the original PR
Observed CI failures
The error logs of the failed CI runs in the original PR #78 seem to have expired and are no longer available, so I re-ran the CI in my forked repo and observed the following failures in the Windows latest (2025) x {pg14, pg17} cases:
https://github.com/mmizutani/temporal_tables/actions/runs/20904227684
pg_ctlreported:service "postgresql-x64-17" already registeredpostgresql-x64-17service registered. The workflow attempted topg_ctl registerthe same service name, so the service registration did not reliably point at the newly initializedC:\\pgdatacluster.Get-Content .\\regression.diffs | Out-Printerthen failed with:Cannot find path ... regression.diffs because it does not existThese failures might be different from what the original PR saw two months ago, though.
Key changes
This PR fixes the CI failures above with the following changes:
pg_ctl unregisterit before initializing/registering the new cluster.C:\\pgdatabeforeinitdb.PGPORT=55432and register the service with-o "-p 55432".PGHOST=localhostto make connections explicit.pg_regressinvocation and outputsPG_ROOT\\bintoPATHto stabilize DLL resolution.With these fixes, the Windows 2025 CI matrix tests are passing for all the versions of Postgres 9.3 - 17.0:
https://github.com/mmizutani/temporal_tables/actions/runs/20908057518
windows build (17.0-1, x64)