Skip to content

Relaunch Cordova app if not running#222

Merged
soumak77 merged 7 commits intoarnesson:masterfrom
Taracque:master
May 2, 2018
Merged

Relaunch Cordova app if not running#222
soumak77 merged 7 commits intoarnesson:masterfrom
Taracque:master

Conversation

@Taracque
Copy link
Copy Markdown
Contributor

If no notification callback, the MainActivity of the app is launched. With this the app gets the data notification even if swiped out from recent apps list, or phone is rebooted.

@drptbl
Copy link
Copy Markdown
Contributor

drptbl commented May 11, 2017

If application is killed and notification is received, this code causes application to start in foreground.

This pull request solves this:
Taracque#2

Jakub Mucha and others added 4 commits May 11, 2017 23:32
@hirbod
Copy link
Copy Markdown
Contributor

hirbod commented May 2, 2018

@soumak77 isn‘t this PR legit. Just read the code but looks important?

@remisture
Copy link
Copy Markdown

Is this for Android only? I desperately need this for both iOS and Android. Opening push messages for killed apps has to be important for others as well? Or am I the only one still facing this problem?

@hirbod
Copy link
Copy Markdown
Contributor

hirbod commented May 2, 2018

iOS is working fine for me, I also did not have any issues on Android but I’ve seen a lot of people complaining so this PR has to be reviewed.

@soumak77 soumak77 merged commit 6552f41 into arnesson:master May 2, 2018
@hirbod
Copy link
Copy Markdown
Contributor

hirbod commented May 2, 2018

Did you test this on android? I did not.

@soumak77
Copy link
Copy Markdown
Contributor

soumak77 commented May 2, 2018

@hirbod I have not. I will wait to release a new version until I get confirmation the plugin is working as desired when installed from github.

@remisture
Copy link
Copy Markdown

Sounds like this plugin needs a better test regime.

@hirbod
Copy link
Copy Markdown
Contributor

hirbod commented May 2, 2018

At least it has a travis ci :D

@soumak77
Copy link
Copy Markdown
Contributor

soumak77 commented May 2, 2018

@remisture agreed, currently the test suite only builds a basic app to verify the build isn't broken, but doesn't actually test any functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants