Skip to content

Replace the Prisma GraphQL extension with Apollo’s#3

Merged
orta merged 1 commit intomasterfrom
add-vscode-apollo
Nov 30, 2018
Merged

Replace the Prisma GraphQL extension with Apollo’s#3
orta merged 1 commit intomasterfrom
add-vscode-apollo

Conversation

@alloy
Copy link
Copy Markdown
Contributor

@alloy alloy commented Nov 30, 2018

The required fix for the extension has been merged, so just waiting for a new release now. apollographql/apollo-tooling#769

@orta
Copy link
Copy Markdown
Contributor

orta commented Nov 30, 2018

Yep, I wonder if this will un-install it for folks - will make a release when I get into the office

@alloy
Copy link
Copy Markdown
Contributor Author

alloy commented Nov 30, 2018

I doubt it will uninstall. Might be a good idea to send a @-here in the channel that people should uninstall the other 2.

@orta
Copy link
Copy Markdown
Contributor

orta commented Nov 30, 2018

Per-repo we can define "unwanted" we might be able to do that here

@orta orta merged commit c821415 into master Nov 30, 2018
@alloy alloy deleted the add-vscode-apollo branch November 30, 2018 16:34
@jbaxleyiii
Copy link
Copy Markdown

@alloy @orta wanted to let you know that the new extension is being verified on the store right now! Please let us know if it works well for you and any features you'd like to see. I'd love to see it working in a Relay app at some point 😄 and see if the rest of the platform like the schema reg would be valuable for Artsy!

@alloy
Copy link
Copy Markdown
Contributor Author

alloy commented Nov 30, 2018

@jbaxleyiii Thanks! Pretty much everything seems to work well thus far (you can try it with this repo) 👍

The only thing that’s not working well right now is in operation variables validation. Relay Modern has the @argumentDefinition directive, which defines ‘local’ variables. These don’t need to be declared at the root of the operation, which currently leads to the many false positives seen below. It would be nice to either have that work or be able to disable that validation rule:

screen shot 2018-12-01 at 00 29 47

@jbaxleyiii
Copy link
Copy Markdown

Okay great! I’m going to try and play around with this tonight / this weekend. Im particularly interested in making sure operation extraction (and by extension validation) works for all kinds of clients!

I’ve been thinking through adding custom validation rules as part of the config as well for more advanced cases. Thanks for the playground repo 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants