Skip invalid executables

src/common/server.ts

@@ -31,6 +31,8 @@ import {
   supportsNativeServer,
   versionToString,
   VersionInfo,
+  MINIMUM_SUPPORTED_EXECUTABLE_VERSION,
+  supportsExecutable,
   MINIMUM_NATIVE_SERVER_VERSION,
   supportsStableNativeServer,
   NATIVE_SERVER_STABLE_VERSION,
@@ -83,6 +85,28 @@ async function getRuffVersion(executable: string): Promise<VersionInfo> {
   return { major, minor, patch };
 }
 
+/**
+ * Validate and log executable from given path.
+ */
+async function validateUsingExecutable(executable: string, strategy: string) {
+  try {
+    const ruffVersion = await getRuffVersion(executable);
+    if (!supportsExecutable(ruffVersion)) {
+      var message = `Skip unsupported executable from ${strategy}: ${executable}`;
+      message += `(Reqiuired at least ${versionToString(
+        MINIMUM_SUPPORTED_EXECUTABLE_VERSION,
+      )}, but found ${versionToString(ruffVersion)} instead)`;
+      traceError(message);
+      return false;
+    }
+    traceInfo(`Using ${strategy}: ${executable}`);
+    return true;
+  } catch (ex) {
+    traceInfo(`Skip invalid executable from ${strategy}: ${executable}`);
+    return false;
+  }
+}
+
 /**
  * Finds the Ruff binary path and returns it.
  *
@@ -110,8 +134,7 @@ async function findRuffBinaryPath(
   // 'path' setting takes priority over everything.
   if (settings.path.length > 0) {
     for (const path of settings.path) {
-      if (await fsapi.pathExists(path)) {
-        traceInfo(`Using 'path' setting: ${path}`);
+      if (await fsapi.pathExists(path) && await validateUsingExecutable(path, "'path' setting")) {
         return path;
       }
     }
@@ -142,16 +165,14 @@ async function findRuffBinaryPath(
     traceError(`Error while trying to find the Ruff binary: ${err}`);
   }
 
-  if (ruffBinaryPath && ruffBinaryPath.length > 0) {
-    // First choice: the executable found by the script.
-    traceInfo(`Using the Ruff binary: ${ruffBinaryPath}`);
+  // First choice: the executable found by the script.
+  if (ruffBinaryPath && ruffBinaryPath.length > 0 && await validateUsingExecutable(ruffBinaryPath, "the Ruff binary")) {
     return ruffBinaryPath;
   }
 
   // Second choice: the executable in the global environment.
   const environmentPath = await which(RUFF_BINARY_NAME, { nothrow: true });
-  if (environmentPath) {
-    traceInfo(`Using environment executable: ${environmentPath}`);
+  if (environmentPath && await validateUsingExecutable(environmentPath, "environment executable")) {
     return environmentPath;
   }
 

src/common/version.ts

@@ -34,6 +34,18 @@ function versionGte(a: VersionInfo, b: VersionInfo): boolean {
   return false;
 }
 
+/**
+ * The minimum version of the Ruff executable that supports the native server.
+ */
+export const MINIMUM_SUPPORTED_EXECUTABLE_VERSION: VersionInfo = { major: 0, minor: 1, patch: 0 };
+
+/**
+ * Check if the given version of the Ruff executable supports the native server.
+ */
+export function supportsExecutable(version: VersionInfo): boolean {
+  return versionGte(version, MINIMUM_SUPPORTED_EXECUTABLE_VERSION);
+}
+
 /**
  * The minimum version of the Ruff executable that supports the native server.
  */