ruff format --check --silent still output the same log as with --quiet

[lephuongbg]

Summary

I'm trying to set-up ruff format --check in precommit hook and would like it to only return an exit code, instead of outputting anything.

The description of ruff format --check --silent says "Disable all logging (but still exit with status code "1" upon detecting diagnostics)", which is what I need but when actually running it, it still shows "Would reformat: [filename]"

Version

0.11.7

[MichaReiser]

We would also need to wrap the line printing the stats here

ruff/crates/ruff/src/commands/format.rs

Lines 194 to 205 in 8619317

	match mode {
	FormatMode::Write => {}
	FormatMode::Check => {
	results.write_changed(&mut stdout().lock())?;
	}
	FormatMode::Diff => {
	results.write_diff(&mut stdout().lock())?;
	}
	}
	// Report on the formatting changes.
	if config_arguments.log_level >= LogLevel::Default {

by a if self.log_level >= LogLevel::Default { check

[Kalmaegi]

I'll try to solve this problem.

[rodmarkun]

Hi, this has been paused for quite a while. Can I work on this? Thanks!

[ntBre]

Hmm, the linked PR looks fairly far along. @Kalmaegi were you waiting for more review feedback, or would you rather someone else pick up the PR? No pressure either way!

[Kalmaegi]

Hmm, the linked PR looks fairly far along. @Kalmaegi were you waiting for more review feedback, or would you rather someone else pick up the PR? No pressure either way!

sorry I’m late, I’m not sure if my current commit is good enough yet, or if it’s ready to be approved and merged.