Identical/duplicate rules: compare-with-tuple (SIM109) and repeated-equality-comparison (PLR1714)

[GideonBear]

Summary

The rules compare-with-tuple (SIM109) and repeated-equality-comparison (PLR1714) do (mostly) the same, resulting in duplicate lints: playground

Note that on SIM109 seems to only work on variables. When using literals: playground

I propose removing one of the rules, similarly to repeated-isinstance-calls (PLR1701).

Alternatively, the relation between these two rules should be explained in the documentation, and the PLR1714 should be suppressed when SIM109 is also found, to avoid duplicate lints.

Version

ruff 0.14.10

[ntBre]

Thanks! I hadn't noticed these, but they do sound basically identical. I'm surprised they didn't appear in the analysis in #12481, but maybe the literal vs variable handling made them look different enough.

I'll put this on the milestone to consider deprecating one of these in the next minor release.