Implement remaining `pycodestyle` rules

[charliermarsh]

Note: some of the checked-off rules are still gated behind the logical_lines feature flag. To see the list of rules enabled in the current release, refer to the docs.

E1 Indentation

• E101 ("indentation contains mixed spaces and tabs")
• E111 ("indentation is not a multiple of four")
• E112 ("expected an indented block")
• E113 ("unexpected indentation")
• E114 ("indentation is not a multiple of four (comment)")
• E115 ("expected an indented block (comment)")
• E116 ("unexpected indentation (comment)")
• E117 ("over-indented")
• E122 ("continuation line missing indentation or outdented")
• E124 ("closing bracket does not match visual indentation")
• E125 ("continuation line with same indent as next logical line")
• E127 ("continuation line over-indented for visual indent")
• E128 ("continuation line under-indented for visual indent")
• E129 ("visually indented line with same indent as next logical line")
• E131 ("continuation line unaligned for hanging indent")

E2 Whitespace

• E201 ("whitespace after ‘(’")
• E202 ("whitespace before ‘)’")
• E203 ("whitespace before ‘,’, ‘;’, or ‘:’")
• E211 ("whitespace before ‘(’")
• E221 ("multiple spaces before operator")
• E222 ("multiple spaces after operator")
• E223 ("tab before operator")
• E224 ("tab after operator")
• E225 ("missing whitespace around operator")
• E227 ("missing whitespace around bitwise or shift operator")
• E228 ("missing whitespace around modulo operator")
• E231 ("missing whitespace after ‘,’, ‘;’, or ‘:’")
• E251 ("unexpected spaces around keyword / parameter equals")
• E261 ("at least two spaces before inline comment")
• E262 ("inline comment should start with ‘# ‘")
• E265 ("block comment should start with ‘# ‘")
• E266 ("too many leading ‘#’ for block comment")
• E271 ("multiple spaces after keyword")
• E272 ("multiple spaces before keyword")
• E273 ("tab after keyword")
• E274 ("tab before keyword")
• E275 ("missing whitespace after keyword")

E3 Blank line

• E301 ("expected 1 blank line, found 0")
• E302 ("expected 2 blank lines, found 0")
• E303 ("too many blank lines (3)")
• E304 ("blank lines found after function decorator")
• E305 ("expected 2 blank lines after end of function or class")
• E306 ("expected 1 blank line before a nested definition")

E4 Import

• E401 ("multiple imports on one line")
• E402 ("module level import not at top of file")

E5 Line length

• E501 ("line too long (82 > 79 characters)")
• E502 ("the backslash is redundant between brackets")

E7 Statement

• E701 ("multiple statements on one line (colon)")
• E702 ("multiple statements on one line (semicolon)")
• E703 ("statement ends with a semicolon")
• E704 ("multiple statements on one line (def)")
• E711 ("comparison to None should be ‘if cond is None:’")
• E712 ("comparison to True should be ‘if cond is True:’ or ‘if cond:’")
• E713 ("test for membership should be ‘not in’")
• E714 ("test for object identity should be ‘is not’")
• E721 ("do not compare types, use ‘isinstance()’")
• E722 ("do not use bare except, specify exception instead")
• E731 ("do not assign a lambda expression, use a def")
• E741 ("do not use variables named ‘l’, ‘O’, or ‘I’")
• E742 ("do not define classes named ‘l’, ‘O’, or ‘I’")
• E743 ("do not define functions named ‘l’, ‘O’, or ‘I’")

E9 Runtime

• E901 ("SyntaxError or IndentationError")
• E902 ("IOError")

W1 Indentation warning

• W191 ("indentation contains tabs")

W2 Whitespace warning

• W291 ("trailing whitespace")
• W292 ("no newline at end of file")
• W293 ("blank line contains whitespace")

W3 Blank line warning

• W391 ("blank line at end of file")

W5. Line break warning

• W505 ("doc line too long (82 > 79 characters)")

W6 Deprecation warning

• W605 ("invalid escape sequence ‘x’")

[charliermarsh]

I'm happy to support these, but I likely won't enable them by default -- I'd like them to be opt-in.

[charliermarsh]

(Also that tabulation is incomplete, but I'll finish it up later!)

[charliermarsh]

\cc @saadmk11

[charliermarsh]

I've updated this lint to include all the current pydocstyle rules, less those that are ignored in the default configuration and those that deal with pre-Python 3.7 code.

[charliermarsh]

First we need #1130.

[charliermarsh]

So far I have seven more rules done in #1130.

[pierrepo]

Thanks for this @charliermarsh
I'm using a lot pycodestyle and pydocstyle with my students to teach them PEP8 and PEP257. Using ruff will be a great plus.

[charliermarsh]

#1130 is up to 14 rules. Just trying to knock out a few each days.

[charliermarsh]

Knocked out eight more rules behind the feature flag.