Add missing unit tests for # noqa:-like cases#16659
Merged
dylwil3 merged 1 commit intoastral-sh:micha/ruff-0.10from Mar 12, 2025
Merged
Add missing unit tests for # noqa:-like cases#16659dylwil3 merged 1 commit intoastral-sh:micha/ruff-0.10from
# noqa:-like cases#16659dylwil3 merged 1 commit intoastral-sh:micha/ruff-0.10from
Conversation
# noqa:-like cases
CodSpeed Performance ReportMerging #16659 will degrade performances by 10.81%Comparing Summary
Benchmarks breakdown
|
Contributor
|
dylwil3
approved these changes
Mar 12, 2025
Collaborator
dylwil3
left a comment
There was a problem hiding this comment.
Thanks! Glad they passed 😄
dylwil3
pushed a commit
that referenced
this pull request
Mar 12, 2025
## Summary Follow-up to #16659. This change adds tests for these three cases, which are (also) not covered by existing tests: * `# noqa: A` (lone incomplete code) * `# noqa: A123, B` (complete codes, last one incomplete) * `# noqa: A123B` (squashed codes, last one incomplete)
MichaReiser
pushed a commit
that referenced
this pull request
Mar 13, 2025
MichaReiser
pushed a commit
that referenced
this pull request
Mar 13, 2025
## Summary Follow-up to #16659. This change adds tests for these three cases, which are (also) not covered by existing tests: * `# noqa: A` (lone incomplete code) * `# noqa: A123, B` (complete codes, last one incomplete) * `# noqa: A123B` (squashed codes, last one incomplete)
MichaReiser
pushed a commit
that referenced
this pull request
Mar 13, 2025
MichaReiser
pushed a commit
that referenced
this pull request
Mar 13, 2025
## Summary Follow-up to #16659. This change adds tests for these three cases, which are (also) not covered by existing tests: * `# noqa: A` (lone incomplete code) * `# noqa: A123, B` (complete codes, last one incomplete) * `# noqa: A123B` (squashed codes, last one incomplete)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #16483.
This case is explicitly described in the specification, but it is not covered by any tests:
Test Plan
Unit tests.