Skip to content

Drop a few rules from the preview default set #23879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntBre merged 7 commits into from
Mar 11, 2026
+0 −10
Merged

Drop a few rules from the preview default set #23879

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9a1f7a5
Drop a few rules from the preview default set
ntBre Mar 10, 2026
9e3b50e
drop TRY300, SIM114, and PLR1714
ntBre Mar 10, 2026
0736524
drop SIM102
ntBre Mar 10, 2026
3959950
drop PERF401 and PERF403
ntBre Mar 10, 2026
e309728
drop RET504
ntBre Mar 10, 2026
8b33c31
update snapshots
ntBre Mar 10, 2026
809099f
restore SIM rules
ntBre Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions crates/ruff/tests/cli/lint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4186,13 +4186,10 @@ fn preview_default_rules() -> Result<()> {
pytest-use-fixtures-without-parameters (PT026),
pytest-warns-with-multiple-statements (PT031),
unnecessary-return-none (RET501),
unnecessary-assign (RET504),
duplicate-isinstance-call (SIM101),
collapsible-if (SIM102),
needless-bool (SIM103),
return-in-try-except-finally (SIM107),
enumerate-for-loop (SIM113),
if-with-same-arms (SIM114),
open-file-with-context-handler (SIM115),
multiple-with-statements (SIM117),
in-dict-keys (SIM118),
Expand All @@ -4219,9 +4216,7 @@ fn preview_default_rules() -> Result<()> {
invalid-module-name (N999),
unnecessary-list-cast (PERF101),
incorrect-dict-iterator (PERF102),
manual-list-comprehension (PERF401),
manual-list-copy (PERF402),
manual-dict-comprehension (PERF403),
bare-except (E722),
io-error (E902),
invalid-escape-sequence (W605),
Expand Down Expand Up @@ -4312,7 +4307,6 @@ fn preview_default_rules() -> Result<()> {
manual-from-import (PLR0402),
redefined-argument-from-local (PLR1704),
useless-return (PLR1711),
repeated-equality-comparison (PLR1714),
boolean-chained-comparison (PLR1716),
sys-exit-alias (PLR1722),
if-stmt-min-max (PLR1730),
Expand Down Expand Up @@ -4435,7 +4429,6 @@ fn preview_default_rules() -> Result<()> {
type-check-without-type-error (TRY004),
verbose-raise (TRY201),
useless-try-except (TRY203),
try-consider-else (TRY300),
verbose-log-message (TRY401),
]
",
Expand Down
7 changes: 0 additions & 7 deletions crates/ruff_linter/src/settings/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,9 +521,7 @@ pub const PREVIEW_DEFAULT_SELECTORS: &[RuleSelector] = &[
RuleSelector::rule(RuleCodePrefix::PEP8Naming(codes::PEP8Naming::_999)), // N999
RuleSelector::rule(RuleCodePrefix::Perflint(codes::Perflint::_101)), // PERF101
RuleSelector::rule(RuleCodePrefix::Perflint(codes::Perflint::_102)), // PERF102
RuleSelector::rule(RuleCodePrefix::Perflint(codes::Perflint::_401)), // PERF401
RuleSelector::rule(RuleCodePrefix::Perflint(codes::Perflint::_402)), // PERF402
RuleSelector::rule(RuleCodePrefix::Perflint(codes::Perflint::_403)), // PERF403
RuleSelector::rule(RuleCodePrefix::PygrepHooks(codes::PygrepHooks::_005)), // PGH005
RuleSelector::rule(RuleCodePrefix::Flake8Pie(codes::Flake8Pie::_790)), // PIE790
RuleSelector::rule(RuleCodePrefix::Flake8Pie(codes::Flake8Pie::_794)), // PIE794
Expand Down Expand Up @@ -579,7 +577,6 @@ pub const PREVIEW_DEFAULT_SELECTORS: &[RuleSelector] = &[
RuleSelector::rule(RuleCodePrefix::Pylint(codes::Pylint::R0402)), // PLR0402
RuleSelector::rule(RuleCodePrefix::Pylint(codes::Pylint::R1704)), // PLR1704
RuleSelector::rule(RuleCodePrefix::Pylint(codes::Pylint::R1711)), // PLR1711
RuleSelector::rule(RuleCodePrefix::Pylint(codes::Pylint::R1714)), // PLR1714
RuleSelector::rule(RuleCodePrefix::Pylint(codes::Pylint::R1716)), // PLR1716
RuleSelector::rule(RuleCodePrefix::Pylint(codes::Pylint::R1722)), // PLR1722
RuleSelector::rule(RuleCodePrefix::Pylint(codes::Pylint::R1730)), // PLR1730
Expand Down Expand Up @@ -662,7 +659,6 @@ pub const PREVIEW_DEFAULT_SELECTORS: &[RuleSelector] = &[
RuleSelector::rule(RuleCodePrefix::Flake8Pyi(codes::Flake8Pyi::_064)), // PYI064
RuleSelector::rule(RuleCodePrefix::Flake8Pyi(codes::Flake8Pyi::_066)), // PYI066
RuleSelector::rule(RuleCodePrefix::Flake8Return(codes::Flake8Return::_501)), // RET501
RuleSelector::rule(RuleCodePrefix::Flake8Return(codes::Flake8Return::_504)), // RET504
RuleSelector::rule(RuleCodePrefix::Ruff(codes::Ruff::_007)), // RUF007
RuleSelector::rule(RuleCodePrefix::Ruff(codes::Ruff::_008)), // RUF008
RuleSelector::rule(RuleCodePrefix::Ruff(codes::Ruff::_009)), // RUF009
Expand Down Expand Up @@ -701,11 +697,9 @@ pub const PREVIEW_DEFAULT_SELECTORS: &[RuleSelector] = &[
RuleSelector::rule(RuleCodePrefix::Flake8Bandit(codes::Flake8Bandit::_110)), // S110
RuleSelector::rule(RuleCodePrefix::Flake8Bandit(codes::Flake8Bandit::_112)), // S112
RuleSelector::rule(RuleCodePrefix::Flake8Simplify(codes::Flake8Simplify::_101)), // SIM101
RuleSelector::rule(RuleCodePrefix::Flake8Simplify(codes::Flake8Simplify::_102)), // SIM102
RuleSelector::rule(RuleCodePrefix::Flake8Simplify(codes::Flake8Simplify::_103)), // SIM103
RuleSelector::rule(RuleCodePrefix::Flake8Simplify(codes::Flake8Simplify::_107)), // SIM107
RuleSelector::rule(RuleCodePrefix::Flake8Simplify(codes::Flake8Simplify::_113)), // SIM113
RuleSelector::rule(RuleCodePrefix::Flake8Simplify(codes::Flake8Simplify::_114)), // SIM114
RuleSelector::rule(RuleCodePrefix::Flake8Simplify(codes::Flake8Simplify::_115)), // SIM115
RuleSelector::rule(RuleCodePrefix::Flake8Simplify(codes::Flake8Simplify::_117)), // SIM117
RuleSelector::rule(RuleCodePrefix::Flake8Simplify(codes::Flake8Simplify::_118)), // SIM118
Expand All @@ -730,7 +724,6 @@ pub const PREVIEW_DEFAULT_SELECTORS: &[RuleSelector] = &[
RuleSelector::rule(RuleCodePrefix::Tryceratops(codes::Tryceratops::_004)), // TRY004
RuleSelector::rule(RuleCodePrefix::Tryceratops(codes::Tryceratops::_201)), // TRY201
RuleSelector::rule(RuleCodePrefix::Tryceratops(codes::Tryceratops::_203)), // TRY203
RuleSelector::rule(RuleCodePrefix::Tryceratops(codes::Tryceratops::_300)), // TRY300
RuleSelector::rule(RuleCodePrefix::Tryceratops(codes::Tryceratops::_401)), // TRY401
RuleSelector::rule(RuleCodePrefix::Pyupgrade(codes::Pyupgrade::_001)), // UP001
RuleSelector::rule(RuleCodePrefix::Pyupgrade(codes::Pyupgrade::_003)), // UP003
Expand Down
Loading
⚡