Skip to content

Omit overridden methods for ASYNC109#24648

Merged
charliermarsh merged 1 commit intomainfrom
charlie/ov
Apr 15, 2026
Merged

Omit overridden methods for ASYNC109#24648
charliermarsh merged 1 commit intomainfrom
charlie/ov

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

Summary

Closes #24630.

@charliermarsh charliermarsh added the bug Something isn't working label Apr 15, 2026
@charliermarsh charliermarsh marked this pull request as ready for review April 15, 2026 02:24
@astral-sh-bot astral-sh-bot Bot requested a review from ntBre April 15, 2026 02:24
@astral-sh-bot
Copy link
Copy Markdown

astral-sh-bot Bot commented Apr 15, 2026

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh merged commit e3f71a3 into main Apr 15, 2026
44 checks passed
@charliermarsh charliermarsh deleted the charlie/ov branch April 15, 2026 11:08
@AlexWaygood
Copy link
Copy Markdown
Member

Could we add a note to the rule's docs that adding @override is a way to get Ruff to accept the code, similar to the notes I added for lots of other rules in #21644 ?

@charliermarsh
Copy link
Copy Markdown
Member Author

Done here: #24666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

async-function-with-timeout (ASYNC109) - false positive on overridden methods

4 participants