[ty] Do not suggest argument completion when at value of keyword argument#24669
Merged
dylwil3 merged 5 commits intoastral-sh:mainfrom Apr 16, 2026
Merged
[ty] Do not suggest argument completion when at value of keyword argument#24669dylwil3 merged 5 commits intoastral-sh:mainfrom
dylwil3 merged 5 commits intoastral-sh:mainfrom
Conversation
dylwil3
commented
Apr 16, 2026
Collaborator
Author
|
(I didn't find an existing issue/PR for this but it's both possible and probable that I'm bad at searching GitHub.) |
MichaReiser
approved these changes
Apr 16, 2026
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the following situation:
the completion suggestions began with
y_true=andy_pred=. But it is never the right thing to suggest an argument completion (i.e.something=) when the cursor is at the value of a keyword argument. So this PR introduces an early exit to the logic for deciding to suggest arguments.