Ensure that all Python downloads do not panic on VersionRequest::from(PythonVersion)#19288
Open
zanieb wants to merge 5 commits intoastral-sh:mainfrom
Open
Ensure that all Python downloads do not panic on VersionRequest::from(PythonVersion)#19288zanieb wants to merge 5 commits intoastral-sh:mainfrom
VersionRequest::from(PythonVersion)#19288zanieb wants to merge 5 commits intoastral-sh:mainfrom
Conversation
Iterates the unique Python versions in the embedded download metadata and asserts each one parses as a `VersionRequest`. The `From<&PythonVersion> for VersionRequest` conversion in `discovery.rs` `expect()`s this round-trip, so any failure here causes `uv python upgrade` to panic (issue astral-sh#19277). Currently fails on `["3.14.5rc1"]` because pre-release version requests are rejected when the patch component is non-zero — the bug fixed by PR astral-sh#19286. https://claude.ai/code/session_01XXorTY1DC7vyjTHgf6rhEV
zanieb
commented
May 5, 2026
auto-merge was automatically disabled
May 5, 2026 17:03
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids future regressions like #19277