fix(lock): warning suggests non-existent --no-frozen flag (#19290)#19294
Open
ChrisJr404 wants to merge 1 commit intoastral-sh:mainfrom
Open
fix(lock): warning suggests non-existent --no-frozen flag (#19290)#19294ChrisJr404 wants to merge 1 commit intoastral-sh:mainfrom
ChrisJr404 wants to merge 1 commit intoastral-sh:mainfrom
Conversation
When `uv lock` is invoked with `UV_FROZEN=1` or `frozen` set in workspace configuration, the warning suggested using `--no-frozen`, which is not a valid CLI flag. Drop the suggestion and recommend `--check`, matching the existing CLI `--frozen` warning path. Closes astral-sh#19290
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
uv lockis invoked withUV_FROZEN=1(env) orfrozenset via workspace configuration, the post-success warning suggested using--no-frozen, which does not exist as a CLI flag. Following that hint produces:Drop the bad suggestion and recommend
--checkonly, matching the sibling warning emitted when--frozenis passed on the CLI (introduced in #17859).Old vs new warning
Before:
After:
--checkis defined onLockArgsincrates/uv-cli/src/lib.rs(the public, non-hidden flag for "check if the lockfile is up-to-date") and works regardless of whetherfrozenwas set via env, configuration, or the CLI.Changes
crates/uv/src/commands/project/lock.rs: drop--no-frozenfrom the env/configuration warning text.crates/uv/tests/it/lock.rs: update thelock_frozen_warningsnapshot to match.Test plan
cargo build -p uvcargo fmt --checkcargo clippy -p uv --all-targets -- -D warningscargo test -p uv --test it lock::lock_frozen_warningCloses #19290